Something in 7.4.1 is broke

[Charger440]

Fred

The Darin (7.4.1) zip file does not show up in PCRT as being uploaded but the Porthos (7.4.0) one does. I have tried other files made with 7.4.1 that do NOT work and other ones with 7.4.0 that DO work. I included these files so you can look over them but you might delete them from the board when you get them as they do contain system info

I have looked over them briefly and I can't tell what is different between the two.

[Fred]

Hi Jim. I can't see anything wrong with the files either. What is the actual problem. Aren't the files being uploaded? Or is it PCRT that can't see them?

I didn't change anything related to the uploading of reports. The only thing I changed in the Reporting section was the way the system info reports are created. Now UVK remembers the sections to export, as you requested.

[Charger440]

PCRT will not see the zip files uploaded with 7.4.1 but it does see zip files created on the same machine with 7.4.0. I have no idea what to suggest could be wrong, it's just weird.

[Xander]

In case this matters, I've been corresponding with Luke (PCRT) this week about my own issue and this is from one of his emails:

"the report files can only have letters, numbers, underscores and dashes and must have a .zip extension, lowercase zip"

Turns out my problem was that one of the PHP files had been reverted back to its old version when I was doing some hosting corrections. Re-uploading fixed it.

[Fred]

Thanks Xander. Have you already tested PCRT in the latest UVK version?

[Xander]

Just updated now and ... uploaded ... recognized. No problem here.

[Fred]

Great, thanks again. I'm not able to see anything wrong with the zip files so I will PM Luke asking him to have a look.

[Fred]

I just sent Luke a PM containing the zip files. Hopefully he'll try to find out why it's not working.

[Charger440]

I will try mine again and see.

I uploaded with 7.4.1 from 3 different computers and none of them showed up in PCRT even though the files were uploaded to the server. I tried downgrading my personal laptop to 7.4.0 and it worked just as expected in PCRT.

I can try 7.4.1 from my laptop but based on other tests I see no reason to think it would but, you never know. If computers were predictable and worked right we wouldn't have jobs

[Fred]

I was reading Xander's reply and then I realized there's a white space in the
DARINPC_Darin Hager_20150904225657.zip
file name. Can that be the issue? Do you mind to strip out any white spaces from the file names after uploading, and see if it works that way?

[Charger440]

I can do that... Gimme a few min

[Charger440]

OK, it is NOT a bug in UVK. At least not technically. One file did have a white space in it and when I took that out it worked fine. Another had an additional period in it "K.Linda", once removed that worked fine.

Now we know if UVK can strip the invalid chars out of the names it should work fine. Although, PCRT should be able to handle any legit filename so I think technically the bug lies in PCRT. That being said, at least we know the issue and I think Fred can fix the "bug."

Side note: The version change was coincidence, this most likely would have happened in 7.4.0 as well.

[Fred]

I would prefer if Luke could make PCRT support those characters. It's not hard at all to replace dots and spaces with underscores, but I think it is neater to see the real PC/User name.

[Charger440]

I agree. I think the bug is in PCRT as it should support legal filenames.

[reggaemanu]

Pretty easy to fix for spaces and dot issues (and you can add all the chars you may want by adding them in the preg_match functions).

You just have to change two lines in uvk.php :

Line 63 :

Code: Select all

   return preg_match('/^[a-z0-9_ -\.]+\.(pdf|html|htm|txt|rtf|csv|gz|tar|zip)$/i', $v_filename) ? '1' : '0';

Line 76 :

Code: Select all

echo "<option value='$val'>$val &bull; $attach_date &bull; $attach_size</option>";

And in order to be listed in new available reports you also have to modify one line in common.php :

Line 2186 :

Code: Select all

   return preg_match('/^[a-z0-9_ -\.]+\.(pdf|html|htm|txt|rtf|csv|gz|tar|zip)$/i', $v_filename) ? '1' : '0';

You may want to also modify this one in wo.php if you want to move the report from pc to wo or from wo to pc :

Line 456 (may vary for you cause I modified almost all pcrt files ^^) :

Code: Select all

   return preg_match('/^[a-z0-9_ -\.]+\.(zipfile|zip)$/i', $v_filename) ? '1' : '0';

Let me know if it works for you, I don't think i've modified anything else to fix it but who knows, i've modified too much files today to be sure

[Charger440]

Thank you for the info but this really needs to be an official fix so that you don't have to mod it every time there is a new version. Also, since that is a legal Linux file name, PCRT should recognize it anyway.

[Charger440]

I actually modded the code to show right by the status how many times I had had that device and how much money that person had spent with me. How ever, since the repair people and the sales people are not linked it's hard to get a good figure on that and I had to remod the code for every new version. Just wasn't worth it to me.

[reggaemanu]

Sure, it has to be updated officially ! But for those that don't want to wait that's a 20s fix

I modded almost every single file to adapt it for my country laws/tax system/accounting system/needs and preferences. I use groups as customers and forced to create a group at each sale if it doesn't exist so for me it is kinda linked, I'll take a look to display how much money they spent, thanks for the idea

[Charger440]

Really the only thing I need is I am fixing to start maintenance contracts and I realize there is yearly billing but what I need is a way to track the people that have that contract and the stats of said contact along with automatic discounting of service charges for those customers.

PCRT help is nothing like Fred's. Fred puts out detailed help for all his products where as there is still not a help file for PCRT that I am aware of.

Your welcome on the idea!

So you have to modify PCRT that much just for your local laws and taxes? Where do you live?

[reggaemanu]

I'm in France

Well I've spent weeks to have it like I want I've started with little modifications but i'm ending with a tone of modified lines (and i'm still modifying things everyday)

I don't need reports but I need an invoice for every transaction (for repairs and sales) with the payment method and the customer ID displayed on it so I had to modify a lot a things (pcrt doesn't link invoice or reports to customers (groups) so I modded files and the sql base).
To complicate even more in france there is a 20% taxe called tva but my company is not subject to it and I had to remove part of the tax system to simplify my use of the program.
Plus the entire traduction to french and modifying every documents that I've to print or send to customers.

I've also modded the dymo label printing process (i can now print it directly from the button on the claim ticket printing page instead of going to another page with the preview/settings, then hit print and then reload the previous page, it was just a big big waste of time in the checkin process) and a lot of things that I don't even remember...

PCRT is great but many things doesn't seems logic to me and/or the way we handle things here.